Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add an indicator isIBMi #30714

Closed
wants to merge 1 commit into from
Closed

test: add an indicator isIBMi #30714

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Nov 29, 2019

We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 29, 2019
targos
targos reviewed Nov 29, 2019
View reviewed changes
test/common/index.js Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Nov 29, 2019 •
edited
Loading

The function/property/whatever-it-ends-up-being should be added to test/common/index.mjs too, I think.

cjihrig
cjihrig reviewed Nov 29, 2019
View reviewed changes
test/common/index.js Outdated Show resolved Hide resolved
test/common/index.js Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Nov 29, 2019

The property added here would also need to be documented in test/common/README.md.

@Trott
Copy link
Member

Trott commented Nov 29, 2019 •
edited
Loading

Thinking about this more, I wonder if the thing to do for now is don't even add it to common. It's only used in one test, so just put the check in the test itself. If we find we need to do this in more places, it can be extracted into common at that time.

@sam-github
Copy link
Contributor

I agree, just testing os.type() in the single affected test is the thing to do here.

@mhdawson
Copy link
Member

@sam-github thanks for checking that out and I agree with:

I agree, just testing os.type() in the single affected test is the thing to do here.

@dmabupt
Copy link
Contributor Author

dmabupt commented Nov 30, 2019 •
edited
Loading

There will be more test cases to be skipped in future since some APIs are not supported by IBM i yet, like fs.watch(). And I am working on the list right now. So this is just an initial commit to add this flag to be used in future.

sam-github
sam-github reviewed Nov 30, 2019
View reviewed changes
test/common/index.js Outdated Show resolved Hide resolved
sam-github
sam-github approved these changes Nov 30, 2019
View reviewed changes
Copy link
Contributor

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the inconsistent spelling of IBMi this looks OK to me.

Trott
Trott previously requested changes Nov 30, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be added to index.mjs too. (Feel free to clear this request for changes once that's done.)

@dmabupt
test: add an indicator isIBMi
1cf3c57 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.
@dmabupt dmabupt requested a review from Trott December 1, 2019 13:28
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27253/

richardlau pushed a commit that referenced this pull request Dec 2, 2019
@dmabupt @richardlau
test: add an indicator isIBMi
f0a31e5 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@richardlau
Copy link
Member

Landed in f0a31e5.

@richardlau richardlau closed this Dec 2, 2019
@dmabupt dmabupt deleted the ibmi_test branch December 3, 2019 04:34
targos pushed a commit that referenced this pull request Dec 3, 2019
@dmabupt @targos
test: add an indicator isIBMi
81d81a5 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@dmabupt @targos
test: add an indicator isIBMi
8204a74 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@dmabupt dmabupt mentioned this pull request Dec 6, 2019
Closed
2 tasks
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@dmabupt @MylesBorins
test: add an indicator isIBMi
197b616 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
@dmabupt @BridgeAR
test: skip the unsupported test cases for IBM i
262c66a 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
@dmabupt @BethGriggs
test: add an indicator isIBMi
6105a41 
We have to skip some test cases on IBM i.
On IBM i, process.platform and os.platform() both return aix,
It is not enough to differentiate between IBM i and real AIX system.
Also updated parallel/test-cluster-bind-privileged-port.js for test.

PR-URL: #30714
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@dmabupt @BridgeAR
test: skip the unsupported test cases for IBM i
e28e873 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@dmabupt @targos
test: skip the unsupported test cases for IBM i
9c9138f 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@dmabupt @BethGriggs
test: skip the unsupported test cases for IBM i
c7dafd8 
This is a following PR of #30714.

PR-URL: #30819
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson left review comments

@addaleax addaleax addaleax left review comments

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@sam-github sam-github sam-github approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dmabupt @Trott @sam-github @mhdawson @nodejs-github-bot @richardlau @jasnell @addaleax @targos @cjihrig